[all-commits] [llvm/llvm-project] 5f0367: [mlir][tblgen] Emit interface decls in definition ...

Matthias Springer via All-commits all-commits at lists.llvm.org
Thu Apr 6 20:09:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f036799f4d39c1aa5a6fac0e972050373e9fa78
      https://github.com/llvm/llvm-project/commit/5f036799f4d39c1aa5a6fac0e972050373e9fa78
  Author: Matthias Springer <springerm at google.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

  Log Message:
  -----------
  [mlir][tblgen] Emit interface decls in definition order in the .td file

Interface decls were previously sorted by name. This lead to problems when using interface inheritance when both interfaces are defined in the same .td file. The derived interface must appear after the base interface, otherwise the generated C++ will not compile.

With this change, interfaces will compile as long as the base interface is defined before derived interfaces in the .td file.

Differential Revision: https://reviews.llvm.org/D147689




More information about the All-commits mailing list