[all-commits] [llvm/llvm-project] bc95f2: Revert "Revert "[Modules] Remove unnecessary check...

Richard Smith via All-commits all-commits at lists.llvm.org
Thu Apr 6 15:42:19 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc95f27337c7ed77c28e713c855272848f01802a
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/pr61065.cppm

  Log Message:
  Revert "Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter""

This re-lands commit db987b9589be1eb604fcb74c85b410469e31485f,
previously reverted in commit 1e0709167f5edd330889f51bb203c458bdb5e359,
with a fix for a pre-existing bug in how we write constructor names into
lookup tables that was exposed by that change.

As yet, we've been unable to produce a reduced testcase for this bug,
but we understand the problem: if we write out a lookup table for a
class which has two constructor names, and we only have local lookup
results for one of those constructor names, then we will write out a
lookup table where the "all the constructors" lookup result contains
results for only one of the constructor names.

More information about the All-commits mailing list