[all-commits] [llvm/llvm-project] 03a9a1: [Sema] Fix reporting of invalid shader attribute o...

[rsandifo-arm via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 03a9a1e664de58fb52ce93e9fb73f61e75a5359a
      https://github.com/llvm/llvm-project/commit/03a9a1e664de58fb52ce93e9fb73f61e75a5359a
  Author: Richard Sandiford <richard.sandiford at arm.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaDecl.cpp
    A clang/test/SemaHLSL/entry_shader.hlsl

  Log Message:
  -----------
  [Sema] Fix reporting of invalid shader attribute on HLSL entry function

If the HLSL entry function had a shader attribute that conflicted
with the pipeline stage specified in the target triple, Clang
would emit:

   error: (null) attribute parameters do not match the previous declaration
   conflicting attribute is here

(where the second line doesn't reference an attribute).

This was because the code constructed a dummy attribute that had
only a source location, but no kind or syntax.

Noticed while doing some changes to the attribute handling.

Differential Revision: https://reviews.llvm.org/D147657