[all-commits] [llvm/llvm-project] f79c03: Fix the check in StopInfoBreakpoint for "are we cu...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f79c037b63278bc5b4481a1a55c68e42f0ea1461
      https://github.com/llvm/llvm-project/commit/f79c037b63278bc5b4481a1a55c68e42f0ea1461
  Author: Jim Ingham <jingham at apple.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M lldb/include/lldb/Target/Process.h
    M lldb/source/Target/StopInfo.cpp
    A lldb/test/API/macosx/objc_exception_recognizer/Makefile
    A lldb/test/API/macosx/objc_exception_recognizer/TestObjCRecognizer.py
    A lldb/test/API/macosx/objc_exception_recognizer/main.m

  Log Message:
  -----------
  Fix the check in StopInfoBreakpoint for "are we currently running an expression"

We were checking "WasTheLastResumeForUserExpression" but that returns true even
if that expression was completed, provided we haven't run again.  This uses a
better check.

This is actually fairly hard to trigger.  It happens the first time you hit an
objc_exception_throw breakpoint and invoke that frame recognizer for that.  But
I couldn't trigger it using a Python based frame recognizer.  So I wrote a test
for the objc_exception_throw_breakpoint recognizer which should have been there
anyway...  It fails (the target auto-continues) w/o this patch and succeeds with
it.

Differential Revision: https://reviews.llvm.org/D147587