[all-commits] [llvm/llvm-project] 981294: [Object] Refactor build ID parsing into Object lib.

Daniel Thornburgh via All-commits all-commits at lists.llvm.org
Wed Apr 5 11:25:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9812948d22328e6f810c7654b93b063ce97ecfec
      https://github.com/llvm/llvm-project/commit/9812948d22328e6f810c7654b93b063ce97ecfec
  Author: Daniel Thornburgh <dthorn at google.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h
    M llvm/include/llvm/Object/BuildID.h
    M llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
    M llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
    M llvm/lib/Debuginfod/Debuginfod.cpp
    M llvm/lib/Object/BuildID.cpp
    M llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
    M llvm/lib/ProfileData/RawMemProfReader.cpp
    M llvm/test/DebugInfo/symbolize-filter-markup-parse-fields.test
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

  Log Message:
  -----------
  [Object] Refactor build ID parsing into Object lib.

This makes parsing for build IDs in the markup filter slightly more
permissive, in line with fromHex.

It also removes the distinction between missing build ID and empty build
ID; empty build IDs aren't a useful concept, since their purpose is to
uniquely identify a binary. This removes a layer of indirection wherever
build IDs are obtained.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D147485




More information about the All-commits mailing list