[all-commits] [llvm/llvm-project] 981932: [MLIR] Clarify (test-scf-)parallel-loop-collapsing

Tres via All-commits all-commits at lists.llvm.org
Wed Apr 5 04:41:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 981932bc57aeaa6d4dd02b011d848ed9fa4dd615
      https://github.com/llvm/llvm-project/commit/981932bc57aeaa6d4dd02b011d848ed9fa4dd615
  Author: Tres Popp <tpopp at google.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SCF/Transforms/Passes.h
    M mlir/include/mlir/Dialect/SCF/Transforms/Passes.td
    M mlir/lib/Dialect/SCF/Transforms/ParallelLoopCollapsing.cpp
    A mlir/test/Transforms/invalid-parallel-loop-collapsing.mlir
    M mlir/test/Transforms/parallel-loop-collapsing.mlir
    M mlir/test/Transforms/single-parallel-loop-collapsing.mlir

  Log Message:
  -----------
  [MLIR] Clarify (test-scf-)parallel-loop-collapsing

1. parallel-loop-collapsing is renamed to test-scf-parallel-loop-collapsing.
2. The pass adds various checks to provide error messages instead of
   hitting assert failures.
3. Testing is added to verify these error messages

This is roughly an NFC. The name changes, but all checked behavior
previously would have resulted in an assertion failure. Almost no new
support is added, so this pass is still limited in scope to testing the
transform behaves correctly with input arguments that perfectly match
the ParallelLoop's iterator arg set. The one new piece of functionality
is that invalid operations will now be skipped with an error messages
instead of producing an assertion failure, so the pass can be used with
expected failures for pieces of the IR not cared about with a specific
RUN command.

Differential Revision: https://reviews.llvm.org/D147514




More information about the All-commits mailing list