[all-commits] [llvm/llvm-project] b2f5ab: [SystemZ] Allow any I5 in RotateSelect*

Ilya Leoshkevich via All-commits all-commits at lists.llvm.org
Tue Apr 4 05:01:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b2f5ab6a41e32bfd8151225b6032ca869f4e142f
      https://github.com/llvm/llvm-project/commit/b2f5ab6a41e32bfd8151225b6032ca869f4e142f
  Author: Ilya Leoshkevich <iii at linux.ibm.com>
  Date:   2023-04-04 (Tue, 04 Apr 2023)

  Changed paths:
    M llvm/lib/Target/SystemZ/SystemZInstrFormats.td
    M llvm/lib/Target/SystemZ/SystemZOperands.td
    M llvm/test/MC/SystemZ/insn-bad-z196.s
    M llvm/test/MC/SystemZ/insn-bad-zEC12.s
    M llvm/test/MC/SystemZ/insn-bad.s
    M llvm/test/MC/SystemZ/insn-good-z196.s
    M llvm/test/MC/SystemZ/insn-good-zEC12.s
    M llvm/test/MC/SystemZ/insn-good.s

  Log Message:
  -----------
  [SystemZ] Allow any I5 in RotateSelect*

For all RotateSelect* instructions, PoP says:

    Bits 0-1 of the I5 field (bits 32-33 of the instruction) are
    ignored.

LLVM, however, completely prohibits using them, e.g.:

    error: invalid operand for instruction
    asm("rxsbg %[r1],%[r2],177,43,228\n"

Lift this unnecessary restriction.

Reviewed By: uweigand

Differential Revision: https://reviews.llvm.org/D146185




More information about the All-commits mailing list