[all-commits] [llvm/llvm-project] 04798d: [mlir][Vector][NFC] Small vector masking clean-up

Diego Caballero via All-commits all-commits at lists.llvm.org
Mon Apr 3 15:00:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04798db4ea42e201adc4d91a9452235a15fd59e8
      https://github.com/llvm/llvm-project/commit/04798db4ea42e201adc4d91a9452235a15fd59e8
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/test/Dialect/Linalg/vectorization.mlir

  Log Message:
  -----------
  [mlir][Vector][NFC] Small vector masking clean-up

We stored static (int) and dynamic (Value) iteration space dims separately
and then merged them by creating constant ops for the static ones. This
merge happened multiple times during vectorization. This PR changes that
to perform the merge once and store in the state instead of the dynamic
values in isolation.

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D147351


  Commit: 5217782014f4cb29fb71737e7baa6750a66024e5
      https://github.com/llvm/llvm-project/commit/5217782014f4cb29fb71737e7baa6750a66024e5
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/test/Dialect/Linalg/vectorization.mlir

  Log Message:
  -----------
  [mlir][Vector] Enable masking for ops with index semantics

Masking was already supported for linalg.index and n-D extract but
disabled while waiting for some n-D extract vectorization patches to
land. This patch is just enabling masking for them and adding a couple
of tests.

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D147359


Compare: https://github.com/llvm/llvm-project/compare/d78ceeba986b...5217782014f4


More information about the All-commits mailing list