[all-commits] [llvm/llvm-project] a71bc5: [mlir] Improve FieldParser list container detection

rk via All-commits all-commits at lists.llvm.org
Mon Apr 3 12:13:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a71bc5f56d1f992bfd1de2f8e2279b6d5338c6db
      https://github.com/llvm/llvm-project/commit/a71bc5f56d1f992bfd1de2f8e2279b6d5338c6db
  Author: rkayaith <rkayaith at gmail.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M mlir/include/mlir/IR/DialectImplementation.h
    M mlir/test/lib/Dialect/Test/TestAttrDefs.td
    M mlir/test/lib/Dialect/Test/TestAttributes.cpp
    M mlir/test/mlir-tblgen/attr-or-type-format-roundtrip.mlir
    M mlir/test/mlir-tblgen/attr-or-type-format.mlir

  Log Message:
  -----------
  [mlir] Improve FieldParser list container detection

The current detection logic will fail for containers with an overloaded
`push_back` member. This causes issues with types like `std::vector` and
`SmallVector<SomeNonTriviallyCopyableT>`, which have both
`push_back(const T&)` and `push_back(T&&)`.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D147101




More information about the All-commits mailing list