[all-commits] [llvm/llvm-project] b18835: [X86] lowerShuffleOfExtractsAsVperm - move hasOneU...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sun Apr 2 11:16:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b18835f1c223baac797a255dd360b7e8515843e6
      https://github.com/llvm/llvm-project/commit/b18835f1c223baac797a255dd360b7e8515843e6
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2023-04-02 (Sun, 02 Apr 2023)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] lowerShuffleOfExtractsAsVperm - move hasOneUse checks to the end of the match. NFCI.

Check the cheap parts of the pattern first, and make the more expensive hasOneUse() call as late as possible.


  Commit: 741298ad06e3a8aa9c68d6ff50ba71d16891e00e
      https://github.com/llvm/llvm-project/commit/741298ad06e3a8aa9c68d6ff50ba71d16891e00e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2023-04-02 (Sun, 02 Apr 2023)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] combineX86ShufflesConstants - move hasOneUse check as late as possible. NFC.

We only need to check hasOneUse if we're optimizing for size, so move the call at the end of the if check.


Compare: https://github.com/llvm/llvm-project/compare/e5bdf0f6d255...741298ad06e3


More information about the All-commits mailing list