[all-commits] [llvm/llvm-project] bdf52b: [AMDGPU] Don't bother to use OffsetMode to define ...

Jay Foad via All-commits all-commits at lists.llvm.org
Fri Mar 31 07:04:39 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bdf52b5dfe4c9d1074e51cd432c5364d8e69462a
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SMInstructions.td

  Log Message:
  [AMDGPU] Don't bother to use OffsetMode to define Real SMEM instructions

Various Real classes took an OffsetMode parameter, but only used it
to extract the suffix for the name of the corresponding pseudo. I found
this confusing because you couldn't usefully define and use a different
OffsetMode here, e.g. one with different operand types to affect how the
instruction was printed.

Overall I think it's simpler to just pass in the suffixed pseudo name

Differential Revision: https://reviews.llvm.org/D147242

More information about the All-commits mailing list