[all-commits] [llvm/llvm-project] 16e1f8: Revert "[AMDGPU] Select v_sat_pk_u8_i16"
Pierre van Houtryve via All-commits
all-commits at lists.llvm.org
Fri Mar 31 03:40:10 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 16e1f8e970aad4c92b31b330daf7274e89cca98d
https://github.com/llvm/llvm-project/commit/16e1f8e970aad4c92b31b330daf7274e89cca98d
Author: pvanhout <pierre.vanhoutryve at amd.com>
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
M llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
M llvm/lib/Target/AMDGPU/SIInstructions.td
M llvm/test/CodeGen/AMDGPU/v_sat_pk_u8_i16.ll
Log Message:
-----------
Revert "[AMDGPU] Select v_sat_pk_u8_i16"
This reverts commit 64b45db34a0cd979dae9ca3016e9da517e57b987.
Reason: the patterns are wrong which can result in a miscompilation.
However, fixing the pattern is not trivial due to how i8 values
are handled, and due to the additional type-checking performed by
D147127: trunc/smax/smin are all defined as int ops in the DAG
despite them working on vectors too.
As this is not a much-needed pattern, I prefer reverting for now
until I can find time to properly rewrite the pattern.
More information about the All-commits
mailing list