[all-commits] [llvm/llvm-project] e8bc77: [MachineOutliner] Fix label outlining regression i...

duk via All-commits all-commits at lists.llvm.org
Thu Mar 30 11:45:54 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8bc77ec085cf23a743bf203d526000df8f45946
  Author: duk <37 at cmail.nu>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M llvm/lib/CodeGen/TargetInstrInfo.cpp
    A llvm/test/CodeGen/AArch64/machine-outliner-labels.mir

  Log Message:
  [MachineOutliner] Fix label outlining regression introduced in D125072

Due to a change in the APIs used to determine what instructions can be outlined, the check for label outling was never hit. Instead, all labels were considered invisible, which is the opposite of the intended behavior and causes obscure crashes down the line. We now replicate the original behavior more closely, with explicit checks for known-good and known-bad instruction types.

Reviewed by: paquette

Differential Revision: https://reviews.llvm.org/D147178

More information about the All-commits mailing list