[all-commits] [llvm/llvm-project] 22afe1: DebugInfo: Rebuild dwp debug_info index column fro...

David Blaikie via All-commits all-commits at lists.llvm.org
Tue Mar 28 13:47:35 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 22afe19ac03f5b5db642cbb8ba7022c2ffc09710
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    A llvm/test/tools/llvm-dwp/X86/cu_tu_units_manual_v4.s

  Log Message:
  DebugInfo: Rebuild dwp debug_info index column from v5 indexes more robustly

the v4 rebuilding is a best-effort because it's not possible to reliably
parse the DWO ID as it requires the abbrev section (& if the index isn't
trustworthy then there's no way to find the associated abbrev section
contribution for a given info section contribution)

But in v5 the DWO ID/type signature is in the header and can be rebuilt
losslessly (only at the cost of performance of rescanning/parsing the
headers of all the units), so let's implement that.

the testing isn't /ideal/ - I think the testing should've been
implemented as a hardcoded dwp file with a corrupted/incorrect index,
then the test could've demonstrated that reparsing the index produces
the right answer - but this is a quick port of the existing v5 test back
to v4 so that we don't lose coverage on the v4 codepath now that it's
separated from the v5 codepath.

Differential Revision: https://reviews.llvm.org/D146662

More information about the All-commits mailing list