[all-commits] [llvm/llvm-project] 177cb1: [libc++][NFC] Rename helper function for testing s...
Louis Dionne via All-commits
all-commits at lists.llvm.org
Tue Mar 28 06:59:08 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 177cb1030f5de716143d3883b89acde5240042fb
https://github.com/llvm/llvm-project/commit/177cb1030f5de716143d3883b89acde5240042fb
Author: Louis Dionne <ldionne.2 at gmail.com>
Date: 2023-03-28 (Tue, 28 Mar 2023)
Changed paths:
M libcxx/test/libcxx/containers/sequences/deque/compare.three_way.pass.cpp
M libcxx/test/libcxx/containers/sequences/forwardlist/compare.three_way.pass.cpp
M libcxx/test/std/containers/sequences/list/compare.three_way.pass.cpp
M libcxx/test/support/test_container_comparisons.h
Log Message:
-----------
[libc++][NFC] Rename helper function for testing spaceship
The helper is mis-named, since it won't work as-is on ordered containers
like set and map, because they rely on being able to store keys that are
partial_ordering::unordered, and that's UB for an ordered container.
This was most likely a typo or an unintended naming mistake, since
the function is only used with sequence containers anyway.
Differential Revision: https://reviews.llvm.org/D146991
More information about the All-commits
mailing list