[all-commits] [llvm/llvm-project] e57483: Downgrade reserved module identifier error into a ...

Aaron Ballman via All-commits all-commits at lists.llvm.org
Tue Mar 28 05:54:07 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e574833c2bc46a39150156eb973d0efb142bc618
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaModule.cpp
    M clang/test/Modules/reserved-names-1.cpp

  Log Message:
  Downgrade reserved module identifier error into a warning

Any project that wants to import std; potentially needs to be able to
build a module that does export std;. We silenced the error diagnostic
if the module identified itself as a system header, but this isn't
quite good enough, what we really need is a way to identify a system
module. It would be nice for that feature to be shared among the major
implementations, so this downgrades the diagnostic from an error to a
warning temporarily to give implementers time to determine what that
mechanism will look like. We may convert this warning back into an
error in a future release of Clang, but it's not guaranteed we will do

Fixes https://github.com/llvm/llvm-project/issues/61446
Differential Revision: https://reviews.llvm.org/D146986

More information about the All-commits mailing list