[all-commits] [llvm/llvm-project] 747af2: [OpenMP] Allow more tests to run on AMDGPU

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Mon Mar 27 21:30:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 747af2415519b10259cdd12c700b0aa2f8946c97
      https://github.com/llvm/llvm-project/commit/747af2415519b10259cdd12c700b0aa2f8946c97
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers.cpp
    M openmp/libomptarget/test/mapping/declare_mapper_nested_mappers.cpp
    M openmp/libomptarget/test/mapping/lambda_by_value.cpp
    M openmp/libomptarget/test/mapping/ompx_hold/struct.c
    M openmp/libomptarget/test/offloading/host_as_target.c

  Log Message:
  -----------
  [OpenMP] Allow more tests to run on AMDGPU

This basically works around the printf issue to increase test coverage.

Differential Revision: https://reviews.llvm.org/D146838


  Commit: 5244617e3a03376565afed14713eda4e87e725af
      https://github.com/llvm/llvm-project/commit/5244617e3a03376565afed14713eda4e87e725af
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M openmp/libomptarget/src/omptarget.cpp

  Log Message:
  -----------
  [OpenMP][NFC] Delete dead code

This code may have served a purpose at some point but it has been dead
for a long while. `FromMapperBase` was always `nullptr` which is `false`
which makes the rest of the code dead. Since this has not
affected tests, I delete it for now.


  Commit: 7f7e1749c5bdab8116075c57711f7f11521bb527
      https://github.com/llvm/llvm-project/commit/7f7e1749c5bdab8116075c57711f7f11521bb527
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/OpenMPOpt.cpp
    M llvm/test/Transforms/OpenMP/deduplication.ll
    M llvm/test/Transforms/OpenMP/deduplication_target.ll
    M openmp/libomptarget/test/offloading/atomic-compare-signedness.c

  Log Message:
  -----------
  [OpenMP] Be smarter about the insertion point for deduplication

We can use dominance and avoid the special handling of kernels and
prevent inserting code before allocas accidentally (as happend in the
runtime test).


  Commit: 7ccf4d1ad744355c09d938ba010a6d6f820a735f
      https://github.com/llvm/llvm-project/commit/7ccf4d1ad744355c09d938ba010a6d6f820a735f
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp
    A llvm/test/Transforms/Attributor/reduced/pred_iterator_crash.ll

  Log Message:
  -----------
  [Attributor][FIX] Account for blocks w/o predecessors


  Commit: 3a7cb3d45ad2dce9c3f3e28ade9e0e534a6742d6
      https://github.com/llvm/llvm-project/commit/3a7cb3d45ad2dce9c3f3e28ade9e0e534a6742d6
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/OpenMPOpt.cpp

  Log Message:
  -----------
  [OpenMP] Adjust generic state machine simplification CB

This callback caused us to potentially miss out on call edges if we were
expecting a custom state machine since the custom state machine was not
created but the workers also did not enter the generic one. I have not
observed an issue and don't know how to create a test for sure, but it
is saver to err on the conservative side for now.


Compare: https://github.com/llvm/llvm-project/compare/151b58d80272...3a7cb3d45ad2


More information about the All-commits mailing list