[all-commits] [llvm/llvm-project] 1d1b3c: [RISCV] Remove isCall instruction flag from JAL/JALR

Job Noorman via All-commits all-commits at lists.llvm.org
Mon Mar 27 07:15:22 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d1b3c49531bb80bcd28870d4eafb71d97049e02
  Author: Job Noorman <jnoorman at igalia.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInstrInfo.td

  Log Message:
  [RISCV] Remove isCall instruction flag from JAL/JALR

As far as I can tell, the instruction flags set in the various
RISCVInstrInfo*.td files are always under-approximations. That is,
something like isTerminator will only be set for opcodes that are
*always* terminators.

The exception seems to be isCall; this is set for JAL/JALR while these
instruction are not always calls. This patch proposes to remove isCall
from JAL/JALR for consistency.

A follow-up patch will add more detailed analysis of some instruction
properties based on MCInstrAnalysis.

Reviewed By: asb, craig.topper

Differential Revision: https://reviews.llvm.org/D146437

More information about the All-commits mailing list