[all-commits] [llvm/llvm-project] 0b103e: [clangd] Fix a hover crash on unsigned 64bit value

zyn0217 via All-commits all-commits at lists.llvm.org
Sun Mar 26 19:27:28 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b103edf5b2c6178c2725a9ff085c6ccc866bccb
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  [clangd] Fix a hover crash on unsigned 64bit value

This patch adapts to D140059, which makes an assumption that the
caller of `APSInt::getExtValue` promises no narrowing conversion
happens, i.e., from unsigned int64 to signed int64.

It also fixes clangd/clangd#1557.

Reviewed By: nridge

Differential Revision: https://reviews.llvm.org/D146874

More information about the All-commits mailing list