[all-commits] [llvm/llvm-project] 25557a: Recommit [Modules] Remove unnecessary check when g...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Wed Mar 22 20:22:25 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 25557aa38a0dab76f5b7a4518942f69d879693c0
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/pr61065.cppm

  Log Message:
  Recommit [Modules] Remove unnecessary check when generating name lookup table in ASTWriter

Close https://github.com/llvm/llvm-project/issues/61065.

We will avoid writing the names from external AST naturally. But
currently its check is often false positive since we may have already
marked the declarations as external but
DeclContext::hasNeedToReconcileExternalVisibleStorage would be false
after reconciling.

Tested with libcxx's modular build.

This patch can improve 8% compilation time in an internal workloads.

See the discussion in
to see the information for recommitting.

More information about the All-commits mailing list