[all-commits] [llvm/llvm-project] 087b5f: [RISCV] Improve validation of opcode for .insn.

Craig Topper via All-commits all-commits at lists.llvm.org
Tue Mar 21 16:20:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 087b5f3277f36225ad26cd265aace89150fe1f06
      https://github.com/llvm/llvm-project/commit/087b5f3277f36225ad26cd265aace89150fe1f06
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
    M llvm/test/MC/RISCV/insn-invalid.s

  Log Message:
  -----------
  [RISCV] Improve validation of opcode for .insn.

The lower 2 bits of the opcode must be 0x3. If the lower 2 bits are
0-2, it's a compressed instruction.

Merge 3 slightly different error messages into 1 to reduce code. The
messages differed slightly depending on whether we parsed a string
or an expression. The message gets a little more generic, but is no
more generic than what binutils prints.




More information about the All-commits mailing list