[all-commits] [llvm/llvm-project] 0d3f7d: [llvm-readobj] Provide Hash Histogram for all ELFD...

Paul Kirth via All-commits all-commits at lists.llvm.org
Mon Mar 20 17:28:19 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d3f7d2ab333f55cef634e7af834b84e1153e9cf
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M llvm/test/tools/llvm-readobj/ELF/hash-histogram.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  [llvm-readobj] Provide Hash Histogram for all ELFDumper implementations

Previously, the GNUELFDumper was the only implementer for Hash Histograms.
This patch moves the implementation for printHashHistogram and
printGnuHashHistogram into the ELFDumper base class, and allows each
derived class to specialize how it outputs that information.

This change also prevents the JSONELFDumper from emitting invalid JSON,
since the shared implementation in LLVMELFDumper no longer emits a
warning message to the output stream.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D137096

More information about the All-commits mailing list