[all-commits] [llvm/llvm-project] 4e298c: [libc] Make string tests compatible with the Fuchs...

Roland McGrath via All-commits all-commits at lists.llvm.org
Mon Mar 20 10:23:14 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e298c32d558cbe7059bb90e4306c22c6702016e
  Author: Roland McGrath <mcgrathr at google.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M libc/test/UnitTest/MemoryMatcher.h
    M libc/test/src/string/bcopy_test.cpp
    M libc/test/src/string/memmove_test.cpp
    M libc/test/src/string/memory_utils/memory_check_utils.h
    M libc/test/src/string/strsignal_test.cpp

  Log Message:
  [libc] Make string tests compatible with the Fuchsia build

Some test code was doing loose conversions caught by compiler
warnings in  the Fuchsia build.  This included duplicated code
in a few tests that was reconsolidated with the existing header
file copy of the same functions.

The MemoryMatcher abstraction presumes gtest-style matcher support,
which is not available in Fuchsia's zxtest library.  It's avoided
in favor of simpler memory-comparing assertions.

Reviewed By: abrachet

Differential Revision: https://reviews.llvm.org/D146343

More information about the All-commits mailing list