[all-commits] [llvm/llvm-project] 6d33af: [WebAssembly] Add comments on local.tee transforma...

Heejin Ahn via All-commits all-commits at lists.llvm.org
Fri Mar 17 20:16:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6d33affac05a7f30f8b3761a66f81fe63b9f44e1
      https://github.com/llvm/llvm-project/commit/6d33affac05a7f30f8b3761a66f81fe63b9f44e1
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp

  Log Message:
  -----------
  [WebAssembly] Add comments on local.tee transformation

We have a good comment on `TEE` transformation in `RegStackify`:
https://github.com/llvm/llvm-project/blob/547e3456660000a16fc5c2a2f819f1a2b5d35b5d/llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp#L613-L632

And I think it can be helpful to have some more comments on how the
`TEE`s created in `RegStackify` are converted into `LOCAL_TEE`s.

Variable `OldReg` is changed to `DefReg` to be consistent with
`RegStackify`'s comment.

Reviewed By: tlively

Differential Revision: https://reviews.llvm.org/D146084




More information about the All-commits mailing list