[all-commits] [llvm/llvm-project] 93c1a5: [llvm-readobj] Rename JSON Flag fields to be more ...

Paul Kirth via All-commits all-commits at lists.llvm.org
Fri Mar 17 17:05:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 93c1a5f3ddd41e0ec09f38ab0045bd5e92199fd5
      https://github.com/llvm/llvm-project/commit/93c1a5f3ddd41e0ec09f38ab0045bd5e92199fd5
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-03-18 (Sat, 18 Mar 2023)

  Changed paths:
    M llvm/docs/ReleaseNotes.rst
    M llvm/include/llvm/Support/ScopedPrinter.h
    M llvm/test/tools/llvm-readobj/ELF/aarch64-symbols-stother.test
    M llvm/test/tools/llvm-readobj/ELF/mips-symbols-stother.test
    M llvm/test/tools/llvm-readobj/ELF/relocations.test
    M llvm/test/tools/llvm-readobj/ELF/symbol-visibility.test
    M llvm/unittests/Support/ScopedPrinterTest.cpp

  Log Message:
  -----------
  [llvm-readobj] Rename JSON Flag fields to be more consistent

Today the JSON uses `Value` and `RawValue` when printing `Flags`, when really
the `Value` field is always the name of an Enum variant, and `RawValue` is its
underlying numeric value. Similarly, we rename the `RawFlags` key to `Value`,
to match the new scheme. This also allows JSON parsing to use consistent logic
for `Flag` types.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D137091




More information about the All-commits mailing list