[all-commits] [llvm/llvm-project] d60d34: [clangd] Move standard options adaptor to CommandM...

Dmitry Polukhin via All-commits all-commits at lists.llvm.org
Fri Mar 17 03:27:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
      https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
  Author: Dmitry Polukhin <dmitry.polukhin at gmail.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/CompileCommands.h
    M clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    M clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp
    M clang/include/clang/Testing/CommandLineArgs.h
    M clang/include/clang/Tooling/Tooling.h
    M clang/lib/Testing/CommandLineArgs.cpp
    M clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp
    M clang/lib/Tooling/Tooling.cpp
    M clang/unittests/Tooling/ToolingTest.cpp

  Log Message:
  -----------
  [clangd] Move standard options adaptor to CommandMangler

There is a discrepancy between how clangd processes CDB loaded from
JSON file on disk and pushed via LSP. Thus the same CDB pushed via
LSP protocol may not work as expected. Some difference between these two
paths is expected but we still need to insert driver mode and target from
binary name and expand response files.

Test Plan: check-clang-tools

Differential Revision: https://reviews.llvm.org/D143436




More information about the All-commits mailing list