[all-commits] [llvm/llvm-project] ddbcd9: [clang-tidy] Correctly handle evaluation order of ...

[martinboehme via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ddbcd985602dcb5fe78fcf2246cf53922db1f3c3
      https://github.com/llvm/llvm-project/commit/ddbcd985602dcb5fe78fcf2246cf53922db1f3c3
  Author: Martin Braenne <mboehme at google.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/utils/ExprSequence.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp

  Log Message:
  -----------
  [clang-tidy] Correctly handle evaluation order of designated initializers.

As designated initializers show up only in the syntactic form of the
InitListExpr, we need to make sure we're searching both forms of the
InitListExpr when determining successors in the evaluation order.

This fixes a bug in bugprone-use-after-move where previously we erroneously
concluded that two designated initializers were unsequenced. The newly added
tests fail without the fix.

Differential Revision: https://reviews.llvm.org/D145906