[all-commits] [llvm/llvm-project] b60de1: [mlir][sparse] Updating `Merger::foreachTensorLoop...
wren romano via All-commits
all-commits at lists.llvm.org
Wed Mar 15 12:28:03 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: b60de1dfcc15d9505de958fe160b45bea11286f2
https://github.com/llvm/llvm-project/commit/b60de1dfcc15d9505de958fe160b45bea11286f2
Author: wren romano <2998727+wrengr at users.noreply.github.com>
Date: 2023-03-15 (Wed, 15 Mar 2023)
Changed paths:
M mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
M mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
Log Message:
-----------
[mlir][sparse] Updating `Merger::foreachTensorLoopId` to take `LatPointId`
Since all callsites of `foreachTensorLoopId` would simply look up the `LatPointId` to extract its `BitVector`, it's cleaner to let the `Merger` handle that instead. This seems to better capture the intent of the `foreachTensorLoopId` method, and improves decoupling (since it removes a place that leaks the implementation detail that we use `BitVector`).
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D146082
More information about the All-commits
mailing list