[all-commits] [llvm/llvm-project] 8964d7: [clang][RISCV][NFC] Combine RV32/RV64 ABI tests in...

[Alex Bradbury via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8964d7a1d7f3db938f6309d8f65aedd605380a20
      https://github.com/llvm/llvm-project/commit/8964d7a1d7f3db938f6309d8f65aedd605380a20
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    A clang/test/CodeGen/RISCV/riscv32-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-ilp32d-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32d-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32f-abi.c
    R clang/test/CodeGen/RISCV/riscv32-ilp32f-ilp32d-abi.c
    A clang/test/CodeGen/RISCV/riscv32-int128-abi.c
    A clang/test/CodeGen/RISCV/riscv64-abi.c
    R clang/test/CodeGen/RISCV/riscv64-lp64-abi.c
    R clang/test/CodeGen/RISCV/riscv64-lp64-lp64f-abi.c
    R clang/test/CodeGen/RISCV/riscv64-lp64-lp64f-lp64d-abi.c
    R clang/test/CodeGen/RISCV/riscv64-lp64d-abi.c
    R clang/test/CodeGen/RISCV/riscv64-lp64f-lp64d-abi.c

  Log Message:
  -----------
  [clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files

After D134050, it makes sense to combine the RV64 ABI tests into a
single file in order to make it more maintainable (i.e. not having to
split tests based on the combinations of ABIs they're expected to
impact). This patch deletes duplicated tests but doesn't do much further
reorganisation beyond that.

I imagine the logical ordering of tests in the file and comments could
be further improved in the future. My personal feeling is that it's
probably not worth investing the time to try to get this "perfect", and
to instead settle for this incremental step forward. But if there's
reviewer interest in attempting to further iterate, I'm happy to do so.

Differential Revision: https://reviews.llvm.org/D140400