[all-commits] [llvm/llvm-project] ab5eae: [mlir][spirv][NFC] Clean up scf-to-spirv pass

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Tue Mar 14 15:45:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab5eae01646e2a83356ec8fe300bf727dadc87dd
      https://github.com/llvm/llvm-project/commit/ab5eae01646e2a83356ec8fe300bf727dadc87dd
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRV.cpp
    M mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRVPass.cpp

  Log Message:
  -----------
  [mlir][spirv][NFC] Clean up scf-to-spirv pass

This is a clean up before fixing issues identified in this pass by
https://github.com/llvm/llvm-project/issues/61380 and similar issues.

- Move patterns definitions closer to declarations.
- Simplify pattern definitions.
- Drop hand-written pass constructor in favor of an auto-generated on.
- Fix typos in pass description.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D146077




More information about the All-commits mailing list