[all-commits] [llvm/llvm-project] 597cef: [libc] Fix GPU fatbinary dependencies for multi-so...

Joseph Huber via All-commits all-commits at lists.llvm.org
Tue Mar 14 13:04:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 597cef44869af2d7a8c123f2b44f3713bdc54a30
      https://github.com/llvm/llvm-project/commit/597cef44869af2d7a8c123f2b44f3713bdc54a30
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M libc/cmake/modules/LLVMLibCObjectRules.cmake

  Log Message:
  -----------
  [libc] Fix GPU fatbinary dependencies for multi-source object libraries

Summary:
Multi-source object libraries require some additional handling, this
logic wasn't correctly settending the dependency on each filename
individually and was instead using the last one. This meant that only
the last file was built for multi-object libraries.


  Commit: ab107b3fac7e837fa63ca020b98ada0d7c0ca556
      https://github.com/llvm/llvm-project/commit/ab107b3fac7e837fa63ca020b98ada0d7c0ca556
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M libc/cmake/modules/LLVMLibCObjectRules.cmake

  Log Message:
  -----------
  [libc] Fix CMake deduplication `-Xclang` arguments

Summary:
We use `-Xclang` to pass the GPU binary to be embedded. In the case of
multi-source objects this will be passed more than once, but CMake
implicitly deduplicates arguments. Use the special generator to prevent
this from happening.


Compare: https://github.com/llvm/llvm-project/compare/81a150656b7d...ab107b3fac7e


More information about the All-commits mailing list