[all-commits] [llvm/llvm-project] 3d9880: [OpenMP]Skip generating this[:1] map info for non-...

jyu2-git via All-commits all-commits at lists.llvm.org
Tue Mar 14 09:18:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d9880ebbcb7d458753ac73a65b401af94c7b762
      https://github.com/llvm/llvm-project/commit/3d9880ebbcb7d458753ac73a65b401af94c7b762
  Author: Jennifer Yu <jennifer.yu at intel.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M clang/lib/CodeGen/CGOpenMPRuntime.cpp
    M clang/test/OpenMP/target_map_member_expr_codegen.cpp
    M openmp/libomptarget/test/mapping/target_map_for_member_data.cpp

  Log Message:
  -----------
  [OpenMP]Skip generating this[:1] map info for non-member variable.

My change of D14093 is only fixed problem for "pragma target data".

The problem still here for "pragma target"
what I am missing is:
When processing "pragma target data", the VD is passed when call to
emitCombinedEntry, so check VD is null as map for this pointer.

But when processing "pragma target" the VD is passed as nullptr, so
check VD is null is not working.

To fix this I add a new parameter IsMapThis. During the call to
emitCombinedEntry passes true if it is capturing this pointer and use
that instead check of "!VD".

Differential Revision: https://reviews.llvm.org/D146000




More information about the All-commits mailing list