[all-commits] [llvm/llvm-project] 27c4e2: [InstCombine] Return instruction from replaceUse()

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27c4e233104ba765cd986b3f8b0dcd3a6c3a9f89
      https://github.com/llvm/llvm-project/commit/27c4e233104ba765cd986b3f8b0dcd3a6c3a9f89
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
    M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
    M llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp

  Log Message:
  -----------
  [InstCombine] Return instruction from replaceUse()

Same as with other replacement methods, it's generally necessary
to report a change on the instruction itself, e.g. by returning
it from the visit method (or possibly explicitly adding it to the
worklist).

Return Instruction * from replaceUse() to encourage the usual
"return replaceXYZ" pattern.