[all-commits] [llvm/llvm-project] 87296f: [mlir] Don't use -z, defs on sanitizer builds

rk via All-commits all-commits at lists.llvm.org
Mon Mar 13 11:04:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 87296fd3c1c5f8d20be017b3b1295ffbf7bf8e0d
      https://github.com/llvm/llvm-project/commit/87296fd3c1c5f8d20be017b3b1295ffbf7bf8e0d
  Author: Rahul Kayaith <rkayaith at gmail.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M mlir/cmake/modules/AddMLIR.cmake

  Log Message:
  -----------
  [mlir] Don't use -z,defs on sanitizer builds

This works around link errors when building the python bindings with
ASAN, since the ASAN run-time doesn't get linked into shared libraries.
The ASAN docs specficially call out -z,defs as a potential issue:
https://clang.llvm.org/docs/AddressSanitizer.html#usage

closes https://github.com/llvm/llvm-project/issues/60565

Reviewed By: stellaraccident, mehdi_amini

Differential Revision: https://reviews.llvm.org/D145956




More information about the All-commits mailing list