[all-commits] [llvm/llvm-project] a159e5: Reland [RISCV] Fix gaps in IgnoreUnknown=true for ...

Alex Bradbury via All-commits all-commits at lists.llvm.org
Mon Mar 13 08:20:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a159e58c008435ba1992617b5ebfe8eb2d3fccb5
      https://github.com/llvm/llvm-project/commit/a159e58c008435ba1992617b5ebfe8eb2d3fccb5
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M llvm/lib/Support/RISCVISAInfo.cpp
    M llvm/unittests/Support/RISCVISAInfoTest.cpp

  Log Message:
  -----------
  Reland [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString

Prior to this patch, unrecognised z/s/sx/x prefixed extensions were not
ignored when IgnoreUnknown=true.

The first version of this patch, a7313f83b9ca9, incorrectly used
`!isSupportedExtension(Ext)` rather than `!isSupportedExtension(Name)`.
i.e. checked the full substring rather than the split out name, causing
incorrect behaviour when a version is specified. This was fixed and a
new test case addded.

Differential Revision: https://reviews.llvm.org/D145882




More information about the All-commits mailing list