[all-commits] [llvm/llvm-project] 5b1ad4: [libc] Declare __dso_handle in the integration tes...

Siva Chandra via All-commits all-commits at lists.llvm.org
Mon Mar 13 00:47:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b1ad43c2b40896efb06736a9ee4399dbda91fee
      https://github.com/llvm/llvm-project/commit/5b1ad43c2b40896efb06736a9ee4399dbda91fee
  Author: Siva Chandra Reddy <sivachandra at google.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M libc/startup/linux/aarch64/start.cpp
    M libc/startup/linux/riscv64/start.cpp
    M libc/startup/linux/x86_64/start.cpp
    M libc/test/IntegrationTest/test.cpp

  Log Message:
  -----------
  [libc] Declare __dso_handle in the integration test instead of startup.

Fixes #61355. The __dso_handle decl was introduced incorrectly into the startup
objects during the integration test cleanup which moved the integration tests
away from using an artificial sysroot to using -nostdlib. Having it in the
startup creates the duplicate symbol error when one does not use -nostdlib.
Since this is an integration test only problem, it is meaningful to keep it in
the integration test anyway.

Differential Revision: https://reviews.llvm.org/D145898


  Commit: 2869d31a7ac1e4748d171711614e9a89dfc0f75a
      https://github.com/llvm/llvm-project/commit/2869d31a7ac1e4748d171711614e9a89dfc0f75a
  Author: Siva Chandra Reddy <sivachandra at google.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M libc/test/CMakeLists.txt
    M libc/test/src/CMakeLists.txt

  Log Message:
  -----------
  [libc] Enable integration tests when built with gcc.


Compare: https://github.com/llvm/llvm-project/compare/bb5324988436...2869d31a7ac1


More information about the All-commits mailing list