[all-commits] [llvm/llvm-project] f9dc14: [clang-tidy] Make readability-string-compare check...

[Mike Crowe via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f9dc14cf1f7eadffa7b11b86aaeaee5af26a21c0
      https://github.com/llvm/llvm-project/commit/f9dc14cf1f7eadffa7b11b86aaeaee5af26a21c0
  Author: Mike Crowe <mac at mcrowe.com>
  Date:   2023-03-12 (Sun, 12 Mar 2023)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string
    M clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp

  Log Message:
  -----------
  [clang-tidy] Make readability-string-compare check use <string> header

Improve the generic <string> header by adding another constructor,
std::basic_string::empty and operator!= overload set so that it can be
used to replace the custom implementation in the
readability-string-compare check.

Depends on D145311

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D145312


  Commit: 0a93abd9765809bb13cfdb43794bf17e9ad5e137
      https://github.com/llvm/llvm-project/commit/0a93abd9765809bb13cfdb43794bf17e9ad5e137
  Author: Mike Crowe <mac at mcrowe.com>
  Date:   2023-03-12 (Sun, 12 Mar 2023)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string
    M clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp

  Log Message:
  -----------
  [clang-tidy] Make readability-container-size-empty check using <string> header

Improve the generic <string> header by adding the size() method so that
it can be used to replace the custom implementation in the
readability-container-size-empty check.

This requires fixing an incorrect comparison of a std::wstring with a
char string literal.

Unfortunately, removing the custom basic_string implementation means
fixing the line numbers for many of the checks.

Depends on D145312

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D145313


  Commit: c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec
      https://github.com/llvm/llvm-project/commit/c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec
  Author: Mike Crowe <mac at mcrowe.com>
  Date:   2023-03-12 (Sun, 12 Mar 2023)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string

  Log Message:
  -----------
  [clang-tidy] Provide default template arguments in <string>

Simplify the use of the basic_string and basic_string_view types by
providing default template arguments.

Depends on D145311

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D145724


Compare: https://github.com/llvm/llvm-project/compare/b53ea2b9c5ac...c4918cbf3ba3