[all-commits] [llvm/llvm-project] 461488: [mlir][GPUToLLVM] Fix regression introduced with o...

[zero9178 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4614889a936fe7a69a4760fd765c374002c207c3
      https://github.com/llvm/llvm-project/commit/4614889a936fe7a69a4760fd765c374002c207c3
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
    M mlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir

  Log Message:
  -----------
  [mlir][GPUToLLVM] Fix regression introduced with opaque-pointers when generate GPU launch func parameters

This has caused build failures when enabling opaque pointers for the GPU integration tests as could be seen here:
https://lab.llvm.org/buildbot/#/builders/220/builds/16946 and here https://lab.llvm.org/buildbot/#/builders/61/builds/40822

The gist of the issue was the use of a wrong pointer base type within a GEP. There sadly was no test coverage for either the generating of that GEP, nor is LLVM Dialects GEP verifier currently capable of catching such issues, so it went unnoticed until the integration tests actually attempted to convert it to LLVM IR.

Differential Revision: https://reviews.llvm.org/D145774