[all-commits] [llvm/llvm-project] 552522: [mlir] Enable opaque pointers in LLVM conversion p...

[zero9178 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 552522bef66c56dc4336d5948662f295dd733c0d
      https://github.com/llvm/llvm-project/commit/552522bef66c56dc4336d5948662f295dd733c0d
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/TypeConverter.h
    M mlir/include/mlir/Conversion/LLVMCommon/LoweringOptions.h
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/test/mlir-cpu-runner/bare-ptr-call-conv.mlir

  Log Message:
  -----------
  [mlir] Enable opaque pointers in LLVM conversion passes by default

Part of https://discourse.llvm.org/t/rfc-switching-the-llvm-dialect-and-dialect-lowerings-to-opaque-pointers/68179

When this patch lands any downstream users with custom LLVM conversion passes not yet using opaque pointers will start either experiencing assertions being triggered, null pointer dereferences or at the very least verifier errors. These can be either fixed by switching to opaque pointers or simply disabling opaque pointers in both pass options of any upstream conversion passes and any uses of `LLVMTypeConverter` via the `LowerToLLVMOptions`.

Users using just MLIRs conversion passes to the LLVM Dialect should not experience any change in functionality except when inspecting the output from the passes.

Differential Revision: https://reviews.llvm.org/D145585