[all-commits] [llvm/llvm-project] 1f8a3c: [HIP] Fix temporary files

Yaxun (Sam) Liu via All-commits all-commits at lists.llvm.org
Thu Mar 9 18:42:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f8a3ce325be51a1004657b08a607825447fee1b
      https://github.com/llvm/llvm-project/commit/1f8a3ce325be51a1004657b08a607825447fee1b
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M clang/include/clang/Driver/Driver.h
    M clang/lib/Driver/Driver.cpp
    M clang/test/Driver/hip-link-bc-to-bc.hip
    A clang/test/Driver/hip-temps-linux.hip
    A clang/test/Driver/hip-temps-windows.hip

  Log Message:
  -----------
  [HIP] Fix temporary files

Currently HIP toolchain uses Driver::GetTemporaryDirectory to
create a temporary directory for some temporary files during
compilation. The temporary directories are not automatically
deleted after compilation. This slows down compilation
on Windows.

Switch to use GetTemporaryPath which only creates temporay
files which will be deleted automatically.

Keep the original input file name convention for Darwin host
toolchain since it is needed for deterministic binary
(https://reviews.llvm.org/D111269)

Fixes: SWDEV-386058

Reviewed by: Artem Belevich

Differential Revision: https://reviews.llvm.org/D145509




More information about the All-commits mailing list