[all-commits] [llvm/llvm-project] da79d6: [libc++][test] Uses qualified std::uint32_t.

Mark de Wever via All-commits all-commits at lists.llvm.org
Wed Mar 8 08:05:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: da79d6e177c5467e4a2132e017a347ff51f5228e
      https://github.com/llvm/llvm-project/commit/da79d6e177c5467e4a2132e017a347ff51f5228e
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    M libcxx/test/libcxx/numerics/numeric.ops/midpoint.integer.pass.cpp
    M libcxx/test/libcxx/type_traits/convert_to_integral.pass.cpp
    M libcxx/test/libcxx/type_traits/is_always_bitcastable.compile.pass.cpp
    M libcxx/test/libcxx/utilities/function.objects/unord.hash/murmur2_or_cityhash_ubsan_unsigned_overflow_ignored.pass.cpp
    M libcxx/test/std/atomics/types.pass.cpp
    M libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp
    M libcxx/test/std/experimental/simd/simd.cons/broadcast.pass.cpp
    M libcxx/test/std/experimental/simd/simd.cons/load.pass.cpp
    M libcxx/test/std/experimental/simd/simd.mem/load.pass.cpp
    M libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp
    M libcxx/test/std/experimental/simd/simd.traits/is_simd.pass.cpp
    M libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minus1.pass.cpp
    M libcxx/test/std/numerics/bit/bit.endian/endian.pass.cpp
    M libcxx/test/std/numerics/bit/bit.pow.two/bit_ceil.fail.cpp
    M libcxx/test/std/numerics/bit/bit.pow.two/bit_ceil.pass.cpp
    M libcxx/test/std/numerics/bit/bit.pow.two/bit_floor.pass.cpp
    M libcxx/test/std/numerics/bit/bit.pow.two/bit_width.pass.cpp
    M libcxx/test/std/numerics/bit/bit.pow.two/has_single_bit.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.count/countl_one.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.count/countl_zero.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.count/countr_one.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.count/countr_zero.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.count/popcount.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.rot/rotl.pass.cpp
    M libcxx/test/std/numerics/bit/bitops.rot/rotr.pass.cpp
    M libcxx/test/std/numerics/bit/byteswap.pass.cpp
    M libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.integer.pass.cpp
    M libcxx/test/std/utilities/charconv/charconv.msvc/floating_point_test_cases.hpp
    M libcxx/test/std/utilities/charconv/charconv.msvc/test.cpp
    M libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
    M libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
    M libcxx/test/std/utilities/format/format.functions/format_tests.h
    M libcxx/test/std/utilities/function.objects/unord.hash/integral.pass.cpp
    M libcxx/test/support/atomic_helpers.h

  Log Message:
  -----------
  [libc++][test] Uses qualified std::uint32_t.

The module std does not provide c-types in the global namespace. This
means all these types need to be fully qualified. This is a first step
to convert them by using sed.

Since this is an automated conversion other types like uint64_t are kept
as is.

Note that tests in the directory libcxx/test/std/depr/depr.c.headers
should not be converted automatically. This requires manual attention,
there some test require testing uint32_t in the global namespace. These
test should fail when using the std module, and pass when using the
std.compat module.

A similar issue occurs with atomic, atomic_uint32_t is specified as
  using atomic_uint32_t = atomic<uint32_t>; // freestanding
So here too we need to keep the name in the global namespace in the
tests.

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D145520




More information about the All-commits mailing list