[all-commits] [llvm/llvm-project] 02e8eb: Split getCompileUnitFor{Data, Code}Address.

Mitch Phillips via All-commits all-commits at lists.llvm.org
Tue Mar 7 12:04:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 02e8eb1a438bdb1dc9a97aea75a8c9c748048039
      https://github.com/llvm/llvm-project/commit/02e8eb1a438bdb1dc9a97aea75a8c9c748048039
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

  Log Message:
  -----------
  Split getCompileUnitFor{Data,Code}Address.

Getting compile units for data addresses is much slower, as it often
requires a slow fallback path to walk every DWARF entry, as
data addresses don't fall into the compilation unit ranges.

Most lookups are code addresses, and don't need this logic. Split the
functionality out so that we restore the fast-path behaviour for the
code lookups.

More context at:
https://discourse.llvm.org/t/llvm-symbolizer-has-gotten-extremely-slow/67262

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D145009




More information about the All-commits mailing list