[all-commits] [llvm/llvm-project] 9b1fe5: Delete ActionManager and replace it with a simple ...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Mon Mar 6 23:26:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b1fe5649e546863adba3fdde158b50a213ea954
      https://github.com/llvm/llvm-project/commit/9b1fe5649e546863adba3fdde158b50a213ea954
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M mlir/include/mlir/Debug/Counter.h
    M mlir/include/mlir/IR/Action.h
    M mlir/include/mlir/IR/MLIRContext.h
    M mlir/lib/Debug/DebugCounter.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
    M mlir/unittests/Debug/DebugCounterTest.cpp
    R mlir/unittests/IR/ActionTest.cpp
    M mlir/unittests/IR/CMakeLists.txt

  Log Message:
  -----------
  Delete ActionManager and replace it with a simple callback on the Context

The concept of the ActionManager acts as a sort of "Hub" that can receive
various types of action and dispatch them to a set of registered handlers.
One handler will handle the action or it'll cascade to other handlers.

This model does not really fit the current evolution of the Action tracing
and debugging: we can't foresee a good case where this behavior compose with
the use-case behind the handlers. Instead we simplify it with a single
callback installed on the Context.

Differential Revision: https://reviews.llvm.org/D144811




More information about the All-commits mailing list