[all-commits] [llvm/llvm-project] 24a085: [LLParser] Error out if a name is too long and get...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 24a08593b946ac78c54c57dc52ec005bd7c44aaa
      https://github.com/llvm/llvm-project/commit/24a08593b946ac78c54c57dc52ec005bd7c44aaa
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/test/Assembler/non-global-value-max-name-size.ll

  Log Message:
  -----------
  [LLParser] Error out if a name is too long and gets renamed

Typically names longer than -non-global-value-max-name-size will just get renamed if there is a collision after truncating. This is fine since we typically don't reference Values by name.

However LLParser does reference Values by name, so report an error when that happens, otherwise weird issues can crop up if there are name collisions (e.g. verifier issues with the changed test case because we end up reusing the same block for `testz` and `testa`).

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D145282