[all-commits] [llvm/llvm-project] 5b9d60: Reland D144920 "[scudo] Only prepare PageMap entry...

ChiaHungDuan via All-commits all-commits at lists.llvm.org
Mon Mar 6 08:39:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b9d6097e78d7e3f7a48103057a767bc5a15faf1
      https://github.com/llvm/llvm-project/commit/5b9d6097e78d7e3f7a48103057a767bc5a15faf1
  Author: Chia-hung Duan <chiahungduan at google.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/fuchsia.cpp
    M compiler-rt/lib/scudo/standalone/primary32.h
    M compiler-rt/lib/scudo/standalone/primary64.h
    M compiler-rt/lib/scudo/standalone/release.h
    M compiler-rt/lib/scudo/standalone/tests/release_test.cpp

  Log Message:
  -----------
  Reland D144920 "[scudo] Only prepare PageMap entry for partial region

This reverts commit daaef4c49954cb04ea1831615e0876865a29a08a.

Differential Revision: https://reviews.llvm.org/D144920


  Commit: 436ea5485d02c529e26a7a1007b82d581be016c4
      https://github.com/llvm/llvm-project/commit/436ea5485d02c529e26a7a1007b82d581be016c4
  Author: Chia-hung Duan <chiahungduan at google.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/primary64.h

  Log Message:
  -----------
  [scudo] Mitigate page releasing thrashing

We have the heuristic to determine the threshold of doing page
releasing for smaller size classes. However, in a case that the
memory usage is bouncing between that threshold may result in
frequent try of page releasing but not returning much memory.

This CL add another heuristic to mitigate this problem by increasing
the minimum pages that potentially can be released. Note that this
heuristic is only applied on SizeClassAllocator64. SizeClassAllocator32
has a smaller group size so the overhead is smaller than 64-bit
platform.

Differential Revision: https://reviews.llvm.org/D144768


  Commit: 0bd4499b967909e134fec7fa7b30bebe06835758
      https://github.com/llvm/llvm-project/commit/0bd4499b967909e134fec7fa7b30bebe06835758
  Author: Chia-hung Duan <chiahungduan at google.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/tests/common_test.cpp

  Log Message:
  -----------
  [scudo] Temporarily disable GetRssFromBuffer test

This is a flaky test and may not test the thing it expected to verify.
E.g., it doesn't dirty the pages so the memory usage may not be reflected
on the RSS.

Reviewed By: cferris

Differential Revision: https://reviews.llvm.org/D145126


Compare: https://github.com/llvm/llvm-project/compare/bdb4353ae00a...0bd4499b9679


More information about the All-commits mailing list