[all-commits] [llvm/llvm-project] e969c8: [ADT] Clean up zip iterators. NFC.

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Mon Mar 6 08:17:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e969c803818cf88fb586d58505e956fe02db8696
      https://github.com/llvm/llvm-project/commit/e969c803818cf88fb586d58505e956fe02db8696
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M llvm/include/llvm/ADT/STLExtras.h

  Log Message:
  -----------
  [ADT] Clean up zip iterators. NFC.

*  Use inheriting constructors declarations to avoid introducing the
   `Base` typedef and duplicate constructor definitions. This should make
   things cleaner, especially since `zip_common` also exposes a `Base`
   typedef.
*  Drop unnecessary template parameters.
*  Avoid double negation in `zip_shortest`'s `operator==` and rename the
   comparison function for better readability.

Reviewed By: zero9178

Differential Revision: https://reviews.llvm.org/D145332




More information about the All-commits mailing list