[all-commits] [llvm/llvm-project] 7e4639: [libc++][format] Fixes formatting vector<bool>

Mark de Wever via All-commits all-commits at lists.llvm.org
Sat Mar 4 05:00:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e4639d28f44dd8988ddb5fcc6063de96e3539cd
      https://github.com/llvm/llvm-project/commit/7e4639d28f44dd8988ddb5fcc6063de96e3539cd
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2023-03-04 (Sat, 04 Mar 2023)

  Changed paths:
    M libcxx/include/__bit_reference
    M libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.tests.h
    M libcxx/test/std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.tests.h
    M libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp

  Log Message:
  -----------
  [libc++][format] Fixes formatting vector<bool>

Formatting a const qualified vector<bool> fails to work on libc++. This
is due to our non-conforming type for vector<bool>::const_reference. The
type is a __bit_const_reference<vector> instead of a bool. (This is
fixed in ABI v2.)

This fixes this formatter and enables the test written for it.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D144279




More information about the All-commits mailing list