[all-commits] [llvm/llvm-project] 55cf53: [mlir][Parser] Make parse{Attribute, Type} null-ter...

rk via All-commits all-commits at lists.llvm.org
Fri Mar 3 14:03:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 55cf53fd0f5594eb701b5760729fdc2bd4a70584
      https://github.com/llvm/llvm-project/commit/55cf53fd0f5594eb701b5760729fdc2bd4a70584
  Author: Rahul Kayaith <rkayaith at gmail.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M mlir/include/mlir/AsmParser/AsmParser.h
    M mlir/lib/AsmParser/DialectSymbolParser.cpp
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    M mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
    M mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
    M mlir/unittests/Parser/ParserTest.cpp

  Log Message:
  -----------
  [mlir][Parser] Make parse{Attribute,Type} null-terminate input

`parseAttribute` and `parseType` require null-terminated strings as
input, but this isn't great considering the argument type is
`StringRef`. This changes them to copy to a null-terminated buffer by
default, with a `isKnownNullTerminated` flag added to disable the
copying.

closes #58964

Reviewed By: rriddle, kuhar, lattner

Differential Revision: https://reviews.llvm.org/D145182




More information about the All-commits mailing list