[all-commits] [llvm/llvm-project] 5e0356: [clang/Diagnostic] Use `optional` to disambiguate ...

[Argyrios Kyrtzidis via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5e035651fd3acbb2645abbe80cae332d90eac78a
      https://github.com/llvm/llvm-project/commit/5e035651fd3acbb2645abbe80cae332d90eac78a
  Author: Argyrios Kyrtzidis <kyrtzidis at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M clang/include/clang/Basic/Diagnostic.h
    M clang/lib/Basic/Diagnostic.cpp
    M clang/unittests/Basic/DiagnosticTest.cpp

  Log Message:
  -----------
  [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

"But when would you have a completely empty diagnostic message", you ask dear reader?
That is when there is an empty "#warning" in code.

rdar://106155415

Differential Revision: https://reviews.llvm.org/D145256