[all-commits] [llvm/llvm-project] 578336: [C++20] [Modules] Deprecate to load C++20 Modules ...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57833636816a13ccda53714413c532dc81e3b5ff
      https://github.com/llvm/llvm-project/commit/57833636816a13ccda53714413c532dc81e3b5ff
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSerializationKinds.td
    M clang/lib/Serialization/ASTReader.cpp
    M clang/test/CXX/basic/basic.link/p10-ex2.cpp
    M clang/test/CXX/basic/basic.link/p2.cpp
    M clang/test/CXX/basic/basic.lookup/basic.lookup.argdep/p5-ex2.cpp
    M clang/test/CXX/basic/basic.scope/basic.scope.namespace/p2.cpp
    M clang/test/CXX/module/basic/basic.def.odr/p6.cppm
    M clang/test/CXX/module/basic/basic.link/module-declaration.cpp
    M clang/test/CXX/module/basic/basic.link/p2.cppm
    M clang/test/CXX/module/basic/basic.search/module-import.cppm
    M clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm
    M clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.interface/p1.cppm
    M clang/test/CXX/module/dcl.dcl/dcl.module/p1.cpp
    M clang/test/CXX/module/dcl.dcl/dcl.module/p5.cpp
    M clang/test/CXX/module/module.context/p7.cpp
    M clang/test/CXX/module/module.interface/p1.cpp
    M clang/test/CXX/module/module.interface/p2.cpp
    M clang/test/CXX/module/module.unit/p8.cpp
    M clang/test/Modules/cxx20-10-1-ex2.cpp
    M clang/test/Modules/cxx20-10-2-ex2.cpp
    M clang/test/Modules/cxx20-10-2-ex5.cpp
    M clang/test/Modules/cxx20-10-3-ex1.cpp
    M clang/test/Modules/cxx20-10-3-ex2.cpp
    M clang/test/Modules/cxx20-10-5-ex1.cpp
    M clang/test/Modules/cxx20-import-diagnostics-a.cpp
    M clang/test/Modules/cxx20-import-diagnostics-b.cpp
    A clang/test/Modules/eagerly-load-cxx-named-modules.cppm
    M clang/test/Modules/named-modules-adl-2.cppm
    M clang/test/Modules/named-modules-adl.cppm
    M clang/test/Modules/pr60036.cppm
    M clang/test/SemaCXX/modules.cppm

  Log Message:
  -----------
  [C++20] [Modules] Deprecate to load C++20 Modules eagerly

Close https://github.com/llvm/llvm-project/issues/60824

The form -fmodule-file=<path-to-BMI> will load modules eagerly and the
form -fmodule-file=<module-name>=<path-to-BMI> will load modules lazily.
The inconsistency adds many additional burdens to the implementations.
And the inconsistency looks not helpful and necessary neither. So I want
to deprecate the form -fmodule-file=<path-to-BMI> for named modules.
This is pretty helpful for us (the developers).

Does this change make any regression from the perspective of the users?

To be honest, yes. But I think such regression is acceptable. Here is
the example:

```
// M.cppm
export module M;
export int m = 5;

// N.cpp
// import M; // woops, we forgot to import M.
int n = m;
```

In the original version, the compiler can diagnose the users to import
`M` since the compiler have already imported M. But in the later style,
the compiler can only say "unknown identifier `m`".

But I think such regression doesn't make a deal since it only works if
the user put `-fmodule-file=M.pcm` in the command line. But how can the
user put `-fmodule-file=M.pcm` in the command line without `import M;`?
Especially currently such options are generated by build systems. And
the build systems will only generate the command line from the source
file.

So I think this change is pretty pretty helpful for developers and
almost innocent for users and we should accept this one.

I'll add the release notes and edit the document after we land this.

Differential Revision: https://reviews.llvm.org/D144707